TST/DOC: apply date() with timezones #14085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -544,7 +544,7 @@ There are several time/date properties that one can access from ``Timestamp`` or | |||
| second,"The seconds of the datetime" | |||
| microsecond,"The microseconds of the datetime" | |||
| nanosecond,"The nanoseconds of the datetime" | |||
| date,"Returns datetime.date" | |||
| date,"Returns datetime.date (does not contain timezone information)" | |||
There was a problem hiding this comment.
Can you put maybe the same comment at the line below for the time attribute?
jorisvandenbossche
added
Testing
|
@rockg Thanks! (added 2 really minor comments) |
Current coverage is 85.26% (diff: 100%)@@ master #14085 diff @@
==========================================
Files 139 139
Lines 50492 50492
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 43052 43053 +1
+ Misses 7440 7439 -1
Partials 0 0
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diff